Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EasyBind revision part two #6505

Merged
merged 1 commit into from
May 21, 2020
Merged

EasyBind revision part two #6505

merged 1 commit into from
May 21, 2020

Conversation

tobiasdiez
Copy link
Member

This is the second part of the EasyBind revision. I've replaced/changed a few things which could be expressed more succinctly using some new EasyBind methods.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 20, 2020
Siedlerchr
Siedlerchr approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes it indeed easier to read and understand some code

@Siedlerchr Siedlerchr merged commit d2f8252 into master May 21, 2020
@Siedlerchr Siedlerchr deleted the easybindTwo branch May 21, 2020 17:51
koppor pushed a commit that referenced this pull request May 1, 2023
Squashed 'buildres/csl/csl-styles/' changes from 4728902faa..a985762505
802ad43 
a985762505 Update environmental-and-engineering-geoscience.csl (#6512)
5118058ea0 Update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#6515)
e9830d3f5e Create polish-archives-of-internal-medicine.csl (#6399)
05ef543bd6 Update ieee.csl (#6511)
b6e6292e4b Update universite-de-bordeaux-ecole-doctorale-de-droit.csl (#6510)
af38aba0e9 Create la-nouvelle-revue-du-travail.csl (#6400)
4b23d7a03e Create north-pacific-anadromous-fish-commission-bulletin.csl (#6436)
77ea82a242 Create journal-of-dental-traumatology.csl (#6403)
af4578d1a7 Make magnetic-resonance-in-medicine.csl AMA dependent (#6433)
5467a4f901 Create medizinische-universitaet-innsbruck-vancouver.csl (#6484)
8a3c0a2b9b Update united-states-international-trade-commissio (#6487)
789267a9cb Update cardiff-university-harvard.csl (#6482)
252a5b5c08 Locators in palaeontology journal styles (#6496)
3d2bff0794 Update ecosistemas.csl (#6503)
199baca2c6 Bump nokogiri from 1.13.10 to 1.14.3 (#6504)
feffe61ae4 Update universite-du-quebec-a-montreal-etudes-litteraires-et-semiologie.csl (#6505)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: a985762505418bd63c26a54c59b48e3ed7426953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr